Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] hr_payroll_period: remove warnings #131

Merged
merged 1 commit into from
Jan 8, 2024
Merged

[14.0][FIX] hr_payroll_period: remove warnings #131

merged 1 commit into from
Jan 8, 2024

Conversation

renda-dev
Copy link
Contributor

Remove the following warnings from hr_payroll_period installation;

WARNING devel odoo.fields: Field hr.employee.base.contract_id with unknown comodel_name None 
WARNING devel odoo.fields: Field hr.employee.public.contract_id with unknown comodel_name None 
WARNING devel odoo.fields: Field hr.contract.schedule_pay: unknown parameter 'oldname', if this is an actual parameter you may want to override the method _valid_field_parameter on the relevant model in order to allow it

@OCA-git-bot
Copy link
Contributor

Hi @nimarosa,
some modules you are maintaining are being modified, check this out!

@nimarosa
Copy link
Contributor

nimarosa commented Nov 7, 2023

@renda-dev The changes are ok. Please do not change the version number, it will be changed automatically when i merge this PR. Please make the changes and we can merge this.

nimarosa
nimarosa requested changes Nov 7, 2023
View reviewed changes
hr_payroll_period/__manifest__.py Outdated Show resolved Hide resolved
aleuffre
aleuffre approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renda-dev
Copy link
Contributor Author

Friendly reminder :) @nimarosa

@nimarosa
Copy link
Contributor

nimarosa commented Jan 5, 2024

@renda-dev Test are failing. Pre-commit and runboat.
We can't merge until they are all green. Please check that out and rebase the PR into 14.0 branch to trigger the tests again.

@aleuffre
Copy link
Contributor

aleuffre commented Jan 5, 2024

@renda-dev The changes are ok. Please do not change the version number, it will be changed automatically when i merge this PR. Please make the changes and we can merge this.

As far as I knew, in case of a migration script, you have to change number version manually so it matches the number of the migration folder, no?

@aleuffre
Copy link
Contributor

aleuffre commented Jan 5, 2024

Fixed pre-commit in #139

@renda-dev
Copy link
Contributor Author

Ready! Please, let me know what you think @nimarosa

@nimarosa
Copy link
Contributor

nimarosa commented Jan 8, 2024

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-131-by-nimarosa-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit cd9ce56 into OCA:14.0 Jan 8, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 213dea4. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-fix-hr_payroll_period branch January 8, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleuffre aleuffre aleuffre approved these changes

@nimarosa nimarosa Awaiting requested review from nimarosa

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@renda-dev @OCA-git-bot @nimarosa @aleuffre